>>>>> On Mon, 13 Sep 2010 19:46:34 -0400, Dan Langille said:
> 
> On 9/13/2010 7:21 PM, Phil Stracchino wrote:
> > On 09/13/10 19:04, Doug Sampson wrote:
> >>>> Are you using the --disable-libtool option to configure?  If so,
> >>>> you'll need the attached patch to make it work.
> >>>>
> >>>> __Martin
> >>>
> >>> Yes, I was. On more than one system. I should have mentioned this in
> >> the
> >>> first place. I will investigate applying this patch and report back.
> >>>
> >>
> >> The patch worked. To be accurate, the command as follows:
> >>
> >> # patch<   /path/to/bacula-5.0.3-libz.patch
> >>
> >> resulted in only one out of the four patches being applied (the second).
> >> Manually editing the two files for the remaining three patches did it.
> >> Did I do this wrong?
> >
> > As long as they were applied carefully and at the correct places, manual
> > patching is usually fine.  It's just time-consuming.  If the only
> > problem is a line number offset, patch will usually spot it and apply
> > the patch in the correct place in the code anyway.
> 
> Is this a patch which should be committed to the source tree?

Possibly not as-is.

In particular, the first part of the patch is a hack to remove some unused
functions that happen to reference zlib.  This should really be fixed in the
makefiles if those functions are needed in the future.

The second part of the patch fixes one of the makefiles and is probably OK,
though there might be a better general solution that can be applied to all
makefiles.


> If so, I'll apply it to the FreeBSD port until such time as it is in the 
> tree.  Hmmm, and if not, I'll apply it anyways. It seem to be required.
> 
> Also, should this patch be applied in all cases, or ONLY if using 
> --disable-libtool?

It is only needed if you use --disable-libtool, but it probably doesn't break
the libtool build.  The problem is caused by missing dependent libraries in
the makefiles, which only show up when the non-libtool (static) bacula
libraries are linked into some of the executables.

__Martin

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Bacula-users mailing list
Bacula-users AT lists.sourceforge DOT net
https://lists.sourceforge.net/lists/listinfo/bacula-users