On Sat, Feb 25, 2006 at 05:59:49PM -0500, stan wrote:
> On Thu, Feb 23, 2006 at 10:59:06PM -0500, Ian Turner wrote:
> > 
> > Try the attached patch, and let me know what happens. Implicit rules hurt 
> > make's performance (especially global ones like this), but there are not 
> > many 
> > targets in that directory anyway, so it is probably not a problem.
> > 
> > Index: man/Makefile.am
> > ===================================================================
> > RCS file: /cvsroot/amanda/amanda/man/Makefile.am,v
> > retrieving revision 1.31
> > diff -r1.31 Makefile.am
> > 94c94
> > < $(man_MANS): %: xml-source/%.proc.xml $(srcdir)/xslt/man.xsl
> > ---
> > > %: xml-source/%.proc.xml $(srcdir)/xslt/man.xsl
> 
> Sorry, it's been too long since I did this.
> 
> Here is what my man/Makefile.am looks like:
> 
> 
> Line 93 ---> $(man_MANS): %: $(MANPAGEDIR)/%.proc.xml xslt/man.xsl
> Line 94 --->  $(XSLTPROC) --path xslt/ --output $@ man.xsl $<
> 
> So, I read this as repalce the line:
> 
>       $(XSLTPROC) --path xslt/ --output $@ man.xsl $<
> 
> with
> 
> %: xml-source/%.proc.xml $(srcdir)/xslt/man.xsl
> 
> am I reading this corectly?
> 

No, 94c94 means in the original replace line 94 with line 94 from
the modified version.

The original line is shown with a '<', the replacement with '>',
So it means replace

 < $(man_MANS): %: xml-source/%.proc.xml $(srcdir)/xslt/man.xsl

with

 > %: xml-source/%.proc.xml $(srcdir)/xslt/man.xsl

Note, if I space them differently

  $(man_MANS): %: xml-source/%.proc.xml $(srcdir)/xslt/man.xsl
               %: xml-source/%.proc.xml $(srcdir)/xslt/man.xsl

You can see it is just delete the leading stuff.

I hadn't seen the "%:" in my makefile travels.  I thought that
was going to be the error.  Learn and Live.

jl
-- 
Jon H. LaBadie                  jon AT jgcomp DOT com
 JG Computing
 4455 Province Line Road        (609) 252-0159
 Princeton, NJ  08540-4322      (609) 683-7220 (fax)