On 16/05/16 17:57, Mauro Condarelli wrote:

>> So, I feel that we would like to enforce some peer review. Perhaps the
>> solution is to require 2 maintainers to approve a patch, but I fear that
>> increases the workload/makes the process more fragile.
>
> If You want peer-review we could move to the "patchwork" infrastructure, and 
> retain
> the ML as primary mean, but even there I'm not aware of any way to enforce 
> multiple
> approval, it just makes it possible and traceable.

It is not possible to *enforce* it on GitHub, but it is possible to have
it as a policy that one committer should comment LGTM before another
committer can merge the PR.

(Looks Good To Me)
(Pull Request)

We use this policy at my office and it works quite well.

I have noticed that Docker uses that policy as well. Examples:
https://github.com/docker/docker/pull/22757
https://github.com/docker/docker/pull/22698
https://github.com/docker/docker/pull/22574

Also, note the "Signed-off-by".

-- 
Best regards,
Lars Tobias

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
BackupPC-users mailing list
BackupPC-users AT lists.sourceforge DOT net
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:    http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/