Bruce,

I committed the suggested fix to the 2.5.1 tree.

Thanks

Jean-Louis

Bruce Thompson wrote:

Hi Paddy,

I've located what appears to be the source of the _keytable errors.

in common-src/util.h there appears:

----- BEGIN -----
typedef struct {        /* token table entry */
    char *keyword;
    tok_t token;
} keytab_t;

keytab_t *keytable;
----- END -----

This is declaring an externally visible variable named "keytable" in every source file that includes util.h.

From what I can tell, this is better done as:

----- BEGIN -----
typedef struct {        /* token table entry */
    char *keyword;
    tok_t token;
} keytab_t;

extern keytab_t *keytable;
----- END -----

and adding

keytab_t *keytable

to util.c.

Making this change has resulted in the complete elimination of this error. I do still see warnings about regex (the global library is used rather than amanda's conflicting symbols), but I suspect this is not a significant issue.

I'm checking against the latest subversion sources now to see if I get the same errors around keytable. If so then I'll post a patch here (unless of course someone yells at me that this fix will break something).

Cheers,
Bruce.


On Sep 20, 2006, at 9:44 AM, Paddy Sreenivasan wrote: