Bacula-users

Re: [Bacula-users] Support for HAVE_POSIX_FADVISE on Bacula Client

2015-10-10 14:33:12
Subject: Re: [Bacula-users] Support for HAVE_POSIX_FADVISE on Bacula Client
From: Kern Sibbald <kern AT sibbald DOT com>
To: Phil Stracchino <phils AT caerllewys DOT net>, bacula-users AT lists.sourceforge DOT net
Date: Sat, 10 Oct 2015 11:30:46 -0700
On 10/10/2015 10:16 AM, Phil Stracchino wrote:
> On 10/09/15 22:05, Kern Sibbald wrote:
>> Hello,
>>
>> Thanks for pointing this out. I still have problems imagining that they
>> would define O_RDONLY as 0 in a bitmapped variable!!!
> It makes more sense if you think of it as the absence of O_RDWR.

Unfortunately, it is even more complicated than that, because it is
actually the absence of O_RWRD and O_WRONLY.

In my opinion the original implementation was faulty because O_RDONLY
should really be defined as:

#define O_RDONLY !(O_RWRD&O_RONLY)

See my second to last commit ...

Goan, but that is how it is so now we know, and hopefully it should now
work correctly.

Best regards,
Kern

------------------------------------------------------------------------------
_______________________________________________
Bacula-users mailing list
Bacula-users AT lists.sourceforge DOT net
https://lists.sourceforge.net/lists/listinfo/bacula-users