On Wed, Nov 25, 2009 at 08:44:02AM -0600, Les Mikesell wrote:

> >>>> I agree - almost every "newbie" that picks up BackupPC makes this
> >>>> mistake - the more experienced you are with old-school config files
> >>>> the MORE likely you are to assume changing this is all you need to do.
> >>>>  A note in the docs and/or a link to the "how to change your TOP DIR"
> >>>> page would fix a huge percentage of installation failures.
> >>>>
> >>>> Or just fixing it so changing the config file IS all you have to do :)
> >>> If they need to be the same, why do we need the configuration option in 
> >>> the
> >>> first place?
> >> __TOPDIR__ is a token that gets substituted/replaced during an initial 
> >> install (a step that deb/rpm packagers have already done).  One of the 
> >> places that the actual value is substituted is the value of 
> >> $Conf{TopDir} in the config file.  But that's not the only place and 
> >> that's why you can't change it later.
> > 
> > Well, then we could simply move it out of config.pl into the code which
> > reads config.pl, e.g. have it preloaded into $Config...
> 
> The installer doing the substitution also establishes and moves the code to 
> its 
> runtime location - which the packagers have put elsewhere.  It is 
> approximately 
> the equivalent of wanting to change 'configure' options of some other source 
> package after you've installed a packaged binary.

I'm not talking about installation time.

I figure it works like this:
- someone calls BackupPC::new()
- it takes it's patched-in $TopDir to locate config.pl
- it reads config.pl
- so what's $Config{TopDir} good for except for confusing users?

I'd suggest just removing the setting from config.pl - the code calling
it should already know the correct setting - it's been patched in, isn't
it? Having it in config.pl will only confuse users since they expect it
is easy to change - so let's config.pl reflect what's really going on:
You cannot change it just here.

Tino.

-- 
"What we nourish flourishes." - "Was wir nähren erblüht."

www.lichtkreis-chemnitz.de
www.tisc.de

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
BackupPC-users mailing list
BackupPC-users AT lists.sourceforge DOT net
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:    http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/