Amanda-Users

Re: application/amgtar patch for review

2009-08-21 16:43:16
Subject: Re: application/amgtar patch for review
From: Christopher <chrismcc AT pricegrabber DOT com>
To: amanda users list <amanda-users AT amanda DOT org>
Date: Fri, 21 Aug 2009 13:25:21 -0700
Hello...


On Fri, 2009-08-21 at 12:52 -0700, Christopher wrote:
> Hello...
> 
> On Fri, 2009-08-21 at 14:59 -0400, Jean-Louis Martineau wrote:
> > Patch looks good.
> > 
> > All code that copy/rename listed incremental files should be done only 
> > if it is used.
> > 
> 
> Ouch, that will take me a little longer to do.  My C skills are weak and
> I need to study the logic a bit.
> 


in: 
static char *
amgtar_get_incrname(



@@ -1049,7 +1057,7 @@
     char *errmsg = NULL;
     char *buf;
 
-    if (gnutar_listdir) {
+    if (gnutar_listdir && gnutar_listedincremental) {
        char number[NUM_STR_SIZE];
        int baselevel;
        char *sdisk = sanitise_filename(argument->dle.disk);



Is it really that easy?

in amgtar_backup

    incrname = amgtar_get_incrname(argument,

GPOINTER_TO_INT(argument->level->data));
    cmd = stralloc(gnutar_path);
    my_argv = amgtar_build_argv(argument, incrname, CMD_BACKUP);

I'm not sure exactly what the result will be.  I'll test tomorrow.



confidence level:  well... it compiles for me  ;)


<snip>


-- 
Christopher McCrory
 "The guy that keeps the servers running"
 
chrismcc AT pricegrabber DOT com
 http://www.pricegrabber.com
 
Let's face it, there's no Hollow Earth, no robots, and
no 'mute rays.' And even if there were, waxed paper is
no defense.  I tried it.  Only tinfoil works.



<Prev in Thread] Current Thread [Next in Thread>