Amanda-Users

RE: FW: amrecover problem

2007-05-31 10:16:23
Subject: RE: FW: amrecover problem
From: "McGraw, Robert P." <rmcgraw AT purdue DOT edu>
To: "Jean-Louis Martineau" <martineau AT zmanda DOT com>
Date: Thu, 31 May 2007 10:11:34 -0400
Jean-Louis

There seems to be a problem with solaris 10 /bin/patch. I downloaded the
patch program from sunfreeware and ran the patch and it worked as expected.
I will have to send in a bug report to Sun.

A added the diff file you sent for the amrecover problem and it resolved
this problem.

Thanks very much for your help.

Robert

_____________________________________________________________________
Robert P. McGraw, Jr.
Manager, Computer System                 EMAIL: rmcgraw AT purdue DOT edu
Purdue University                         ROOM: MATH-807
Department of Mathematics                PHONE: (765) 494-6055
150 N. University Street                   FAX: (419) 821-0540
West Lafayette, IN 47907-2067            


> -----Original Message-----
> From: Jean-Louis Martineau [mailto:martineau AT zmanda DOT com]
> Sent: Wednesday, May 30, 2007 4:53 PM
> To: McGraw, Robert P.
> Subject: Re: FW: amrecover problem
> 
> Try this patch instead.
> Or install gnu patch.
> 
> Jean-Louis
> 
> McGraw, Robert P. wrote:
> > Jean-Louis.
> >
> > Thanks for the patch but I am having problems with adding patches from
> you.
> > Any idea what I could be doing wrong. This is the standard patch program
> > that comes with Solaris 10. I should never get the "File to patch:".
> >
> >
> > ##R##-zorn->[133] ##> patch -p1 < amrecoverregex.txt
> >   Looks like a unified context diff.
> > File to patch: ./recover-src/set_commands.c
> >   I can't seem to find a patch in there anywhere.
> >
> > Robert
> >
> >
> >
> >
> >> -----Original Message-----
> >> From: Jean-Louis Martineau [mailto:martineau AT zmanda DOT com]
> >> Sent: Wednesday, May 30, 2007 3:06 PM
> >> To: McGraw, Robert P.
> >> Cc: amanda-users AT amanda DOT org; Chapman Flack
> >> Subject: Re: FW: amrecover problem
> >>
> >> The regex library you use is more strict than mine.
> >>
> >> Try the attached patch.
> >>
> >> Jean-Louis
> >>
> >> McGraw, Robert P. wrote:
> >>
> >>> I am forwarding this from my partner SA.  Is this a know problem with
> a
> >>>
> >> fix
> >>
> >>> or something newly discovered?
> >>>
> >>> Thanks
> >>>
> >>> Robert
> >>>
> >>>
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Chapman Flack [mailto:jflack AT math.purdue DOT edu]
> >>>> Sent: Wednesday, May 30, 2007 12:03 PM
> >>>> To: Robert McGraw
> >>>> Subject: amrecover
> >>>>
> >>>>
> >>>> Robert,
> >>>>
> >>>> Heads up - the cd command seems broken in the latest amrecover. The
> >>>> cdx command still works though, in case you need to recover
> something.
> >>>>
> >>>> Could you forward this to whoever was working with you on patching
> >>>> other problems in amanda recently? I'm not sure this isn't something
> >>>> only we are seeing, so I don't know if it's in the exact distributed
> >>>> sources or it's connected somehow to modifications here.
> >>>>
> >>>> Here's what happens:
> >>>>
> >>>> AMRECOVER Version 2.5.2-20070523. Contacting server on zorn ...
> >>>> 220 zorn AMANDA index server (2.5.2-20070523) ready.
> >>>> Setting restore date to today (2007-05-30)
> >>>> 200 Working date set to 2007-05-30.
> >>>> 200 Config set to daily.
> >>>> Trying host zorn.math ...
> >>>> 501 Host zorn.math is not in your disklist.
> >>>> Trying host zorn ...
> >>>> 200 Dump host set to zorn.
> >>>> Use the setdisk command to choose dump disk to recover
> >>>> amrecover> setdisk /export/users-j
> >>>> 200 Disk set to /export/users-j.
> >>>> amrecover> setdate 2007-05-29
> >>>> 200 Working date set to 2007-05-29.
> >>>> amrecover> cd jflack
> >>>> amrecover: regex "/jflack/$/": unknown regex error
> >>>>
> >>>> ... and amrecover exits out to the shell.
> >>>>
> >>>> The trouble seems to be in set_commands.c where cd_glob()
> >>>> appends a /$ to the target directory, and then calls
> >>>> cd_dir() which appends another / so the result is a regex
> >>>> where $ is not the last character, and that's invalid.
> >>>>
> >>>> Browsing the CVS shows that some of this stuff was changed
> >>>> in set_commands.c in the last few months. It's kind of
> >>>> surprising though to have something as noticeable as cd not
> >>>> working go unnoticed, so I am not sure why I haven't found it
> >>>> discussed.
> >>>>
> >>>> The reason cdx still works is it treats the argument you give
> >>>> as a regex already, so doesn't break it by adding extra
> >>>> characters.
> >>>>
> >>>> -Chap
> >>>>
> >>>>
> >
> >

Attachment: smime.p7s
Description: S/MIME cryptographic signature

<Prev in Thread] Current Thread [Next in Thread>