Amanda-Users

Re: Release of amanda-2.5.0b2

2006-01-31 17:29:16
Subject: Re: Release of amanda-2.5.0b2
From: Jean-Louis Martineau <martineau AT zmanda DOT com>
To: Josef Wolf <jw AT raven.inka DOT de>
Date: Tue, 31 Jan 2006 17:16:00 -0500
Josef,

This simple patch should fix the problem.

Thanks for reporting it.

Jean-Louis

Josef Wolf wrote:
On Tue, Jan 31, 2006 at 06:53:30AM -0500, Jean-Louis Martineau wrote:


I don't see a success report? Where did you see it?


I meant this line:


taper: writing end marker. [VOL02 OK kb 0 fm 0]


But you are right here.  This line say just that VOL02 could be loaded
successfully, 0KB written.  There's nothing that says that the DLE could
successfully be written.


The dump never got written to tape, that's what I see from the log below.


Amanda tried to write onto VOL01, but taper reported that there's no space
left:


driver: startaflush: Using SMALLEST because nothing fit
driver: send-cmd time 4595.439 to taper: FILE-WRITE 00-00010 /m/amchanger/ppc/hold/20060128030558/host.do.main._.0 host.do.main fffffeff9ffeffff03 / 0 20060128 0
driver: startaflush: LARGESTFIT host.do.main / 2650817 1695391
taper: r: switching to next holding chunk '/m/amchanger/ppc/hold/20060128030558/host.do.main._.0.1'
taper: writing end marker. [VOL01 ERR kb 4556768 fm 5]


Amanda never retried to write it to the second tape,


But amanda labelled the tape and wrote the end marker, thus I assume
there were no tape error.


that's a real bug, I will investigated it.


Thanks!

BTW: why does amanda start to write this DLE to VOL01 at all?  She
     knows in advance that the write will fail.  The tapetype says it's
     4450mbytes and there were only about 1.6GB free.  Why does amanda
     starting a 2.6gb DLE to a tape where only 1.6gb will fit?
     Would it be possible (at least for file: vtapes) to delete the
     started but failed DLEs?

diff -u -r --show-c-function --exclude-from=amanda.diff 
amanda-2.5.0b2.orig/server-src/driver.c amanda-2.5.0b2.new/server-src/driver.c
--- amanda-2.5.0b2.orig/server-src/driver.c     2006-01-14 17:11:22.000000000 
-0500
+++ amanda-2.5.0b2.new/server-src/driver.c      2006-01-31 17:03:37.703475200 
-0500
@@ -1204,6 +1204,7 @@ dumper_result(dp)
        enqueue_disk(&runq, dp);
     }
     else if(size > DISK_BLOCK_KB) {
+       sched(dp)->attempted = 0;
        enqueue_disk(&tapeq, dp);
        startaflush();
     }
<Prev in Thread] Current Thread [Next in Thread>