Re: amadmin disklist should print spindle number


Jon LaBadie <jon AT jgcomp DOT com> writes:

> On Thu, Oct 28, 2004 at 10:29:28PM -0700, Kevin Dalley wrote:
>> Here a patch against 2.4.4p4 which prints the spindle number when
>> amadmin disklist is run.  The patch is useful to prevent a problem
>> with an incorrect interpretation of the spindle number.
>> 
>> "diff -u *~ *" in /home/kevin/src/amanda-2.4.4p4/server-src/
>> 
>> --- amadmin.c~       2004-09-17 04:55:08.000000000 -0700
>> +++ amadmin.c        2004-10-28 22:11:46.000000000 -0700
>> @@ -1607,6 +1607,7 @@
>>      printf("        index %s\n", (dp->index? "YES" : "NO"));
>>      printf("        skip-incr %s\n", (dp->skip_incr? "YES" : "NO"));
>>      printf("        skip-full %s\n", (dp->skip_full? "YES" : "NO"));
>> +    printf("        spindle %d\n", (dp->spindle));
>>  
>>      printf("\n");
>>  }
>
> Have you tested this patch on a system where the admin has
> not defined spindle numbers?

Yes.  The spindle number is set, whether or not the administrator
explicitly sets a value.  The reason I added the code is that I had an
amanda.conf which was being misinterpreted.  I had an interface, but
no spindle number.  The spindle number was set to be 0.  After
removing the interface, which wasn't needed anyway, the spindle number
switches to -1.

localhost //bunting/c$ root-sambatar eth0

read a spindle of 0,

was change to:

localhost //bunting/c$ root-sambatar

read a spindle of -1.

-- 
Kevin Dalley
kevin AT kelphead DOT org