Amanda-Users

Re: 2.4.5: dumping directly to tape failure: no retry?

2005-11-02 08:08:00
Subject: Re: 2.4.5: dumping directly to tape failure: no retry?
From: Jean-Francois Malouin <Jean-Francois.Malouin AT bic.mni.mcgill DOT ca>
To: AMANDA users <amanda-users AT amanda DOT org>, Jean-Louis Martineau <martinea AT iro.umontreal DOT ca>
Date: Wed, 2 Nov 2005 07:58:51 -0500
* Jean-Louis Martineau <martinea AT iro.umontreal DOT ca> [20051101 19:56]:
> Hi Jean-Francois,
> 
> Thanks for the good report.
> 
> The problem is the result of the dumper, which is FAILED, in that
> case the dump is not retried.
> 
> Could you try this patch.

I just applied the patch and will let know how it goes.

Thanks a bunch,
jf

> 
> 
> On Tue, Nov 01, 2005 at 11:37:02AM -0500, Jean-Francois Malouin wrote:
> > dumper: driver: result time 23806.848 from dumper0: FAILED 00-00031
> 
> -- 
> Jean-Louis Martineau             email: martineau AT iro.umontreal DOT ca 
> Département IRO, Université de Montréal
> C.P. 6128, Succ. CENTRE-VILLE    Tel: (514) 343-6111 ext. 1-3529
> Montréal, Canada, H3C 3J7        Fax: (514) 343-5834

> --- amanda-2.4.5p1.orig/server-src/dumper.c   2005-09-20 20:11:38.000000000 
> -0400
> +++ amanda-2.4.5p1.new/server-src/dumper.c    2005-11-01 19:42:29.000000000 
> -0500
> @@ -1387,8 +1387,7 @@ int mesgfd, datafd, indexfd, outfd;
>               rc = 2;
>               goto failed;
>           }
> -         if(update_dataptr(&outfd, size1)) {
> -             rc = 2;
> +         if((rc=update_dataptr(&outfd, size1))) {
>               goto failed;
>           }
>           if(size1 == 0) {