Amanda-Users

Re: glob include behavior change ?

2009-11-02 16:57:15
Subject: Re: glob include behavior change ?
From: Jean-Louis Martineau <martineau AT zmanda DOT com>
To: Brian Cuttler <brian AT wadsworth DOT org>
Date: Mon, 02 Nov 2009 16:48:23 -0500
Hi Brian,

The attached should fix the "Too many open files" problem.
Can you try it and tell me the result.

Jean-Louis

Brian Cuttler wrote:
In order to work around the glob issue I removed the globs
from my disklist and replace them with entries for each
user directory.

We at least doubled the number fo entries to one particular
client, from around 50 to around 100.

We encounter a new problem, I don't know if this prevents
backups from occuring or not.

amcheck -c curie
Amanda Backup Client Hosts Check
--------------------------------
ERROR: finsen: service selfcheck: selfcheck: error [open pipe to 
/usr/local/libexec/amanda/application/amzfs-snapshot: Too many open files]
ERROR: finsen: service /usr/local/libexec/amanda/selfcheck failed: pid 12205 
exited with code 1
Client check: 21 hosts checked in 45.182 seconds.  2 problems found.

(brought to you by Amanda 2.6.1p1-20091023)


To work around this I think I'll eliminate snapshots and just
use user-tar... at least for the weekend.





On Fri, Oct 30, 2009 at 02:52:06PM -0400, Brian Cuttler wrote:
We have installed and are running amanda Amanda-2.6.1p1-20091023
and have begun to use BSDTCP, which is workign well and had taken
care of our UDP packet size issues (too make DLE per client).

However it looks like our zfs globs have stopped working, or are
now working somewhat differently.

globs of this format where being used to group together user
directories that EACH have their own ZFS mount points.

The default --one-filesystem (close but perhaps misnamed switch)
for gtar caused us to write globs in this way, allowing us to
limit number of DLE (udp packet size issue) but get the data under
each of the mount points.

This seems to no longer be working with the new amanda snapshot.

Not sure if I need to re-write the DLE... my index files confirm
that I had been getting the data under the user directories, now
I just seem to get the directory file itself.

In this case host and client are both Solaris 10/x86 - but I have
numerous other clients on which I have not updated the amanda client
sofware, on some I do use DLE globs.

finsen  /export/home-A /export/home   {
        zfs-snapshot2
        include "./[a]*"
        }
finsen  /export/home-B /export/home   {
        zfs-snapshot2
        include "./[b]*"
        }


---
   Brian R Cuttler                 brian.cuttler AT wadsworth DOT org
   Computer Systems Support        (v) 518 486-1697
   Wadsworth Center                (f) 518 473-6384
   NYS Department of Health        Help Desk 518 473-0773



IMPORTANT NOTICE: This e-mail and any attachments may contain
confidential or sensitive information which is, or may be, legally
privileged or otherwise protected by law from further disclosure.  It
is intended only for the addressee.  If you received this in error or
from someone who was not authorized to send it to you, please do not
distribute, copy or use it or any attachments.  Please notify the
sender immediately by reply e-mail and delete this from your
system. Thank you for your cooperation.


---
   Brian R Cuttler                 brian.cuttler AT wadsworth DOT org
   Computer Systems Support        (v) 518 486-1697
   Wadsworth Center                (f) 518 473-6384
   NYS Department of Health        Help Desk 518 473-0773



IMPORTANT NOTICE: This e-mail and any attachments may contain
confidential or sensitive information which is, or may be, legally
privileged or otherwise protected by law from further disclosure.  It
is intended only for the addressee.  If you received this in error or
from someone who was not authorized to send it to you, please do not
distribute, copy or use it or any attachments.  Please notify the
sender immediately by reply e-mail and delete this from your
system. Thank you for your cooperation.


diff --git a/client-src/client_util.c b/client-src/client_util.c
index dd5a167..58f1f02 100644
--- a/client-src/client_util.c
+++ b/client-src/client_util.c
@@ -831,7 +831,7 @@ backup_support_option(
        }
        amfree(line);
     }
-    aclose(supportout);
+    fclose(streamout);
 
     if (bsu->data_path_set == 0)
        bsu->data_path_set = DATA_PATH_AMANDA;
@@ -848,7 +848,7 @@ backup_support_option(
        }
        amfree(bsu);
     }
-    aclose(supporterr);
+    fclose(streamerr);
 
     if (waitpid(supportpid, &status, 0) < 0) {
        err = vstrallocf(_("waitpid failed: %s"), strerror(errno));
diff --git a/client-src/selfcheck.c b/client-src/selfcheck.c
index 1c55146..df86e0b 100644
--- a/client-src/selfcheck.c
+++ b/client-src/selfcheck.c
@@ -874,6 +874,7 @@ check_disk(
                    }
                    amfree(line);
                }
+               fclose(app_stderr);
                if (waitpid(application_api_pid, &status, 0) < 0) {
                    err = vstrallocf(_("waitpid failed: %s"),
                                         strerror(errno));
<Prev in Thread] Current Thread [Next in Thread>