Re: release of amanda-2.6.1

Charles Stroom wrote:

Firstly, I removed the 2 redundant lines in my patch -> compile and
build seems still to be ok.

Then, I changed the distver line to 11.1 -> now the error re-occurs:
"
contrib@fiume:~/done/RPMs/amanda> sudo rpmbuild
-ba /usr/src/packages/SPECS/amanda.spec root's password:
error: parse error in expression
error: /usr/src/packages/SPECS/amanda.spec:363: parseExpressionBoolean
returns -1 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.13551
etc.

regards,

Charles


On this line, it seems that rpm can't handle the "." in distver.  Just
to verify, can you alter your patch to re-add the ".1" in distver and
verify that the failure recurs?  If this is the case, we'll need to
adjust our numbering scheme (probably adopting the four-digit format
of suse_version).

Clearly rpmbuild doesn't think that 11.1 is a number, but we rely ondistver to do a number of > or < comparisons, so we can't use change itall to string comparison easily. The method I've seen to handle thiswould be to add something like:

define distver_major 11
define distver_minor 1
define distver %{distver_major}%{?distver_minor: echo .%{distver_minor}}

Then use distver_major wherever you need numerical comparison, anddistver wherever you want the full string. Is there a pressing reasonto use 11.1 vs 11? Was there ever an 11.0 available, and is it still inuse? It's not good to use wrong terminology just because I'm lazy.Although in this case being lazy is keeping the already complicated.spec syntax a little simpler.

It occurs to me that the minor version for Suse/sles might be the theservice pack. Do you have service pack 1 for OpenSuSE 11 installed? isthere such a thing? We did have problems running an RPM built onSles10sp2 on Sles10. I didn't trace down the rpm macros in that casebecause our solution was to install Sles10 instead.I doubt binarycompatibility is broken going forward from 11 to 11.1, so having aseparate rpm for each seems a bit excessive.

I don't know how much value we gain for the increase in complexity.Since we don't test on every minor version of every distro, thisdetection machinery is going to be error prone and likely to cause moreproblems like yours than it will fix.I guess I'd say let's go with 11 vs 11.1 unless there is a problem Idon't know about.

Dan