This problem was fixed a few days after 2.5.1p3 release.

The scale function should be:
off_t
scale(
   off_t r,
   off_t s)
{
   if (r == (off_t)-1)
       return (off_t)-1;
   if (s % 1024 == 0)
       return r*(s/(off_t)1024);
   return (off_t)(r*((double)s/1024.0));
}

Jean-Louis

Peter Kunst wrote:

On 04/25/2007 10:06 PM, Mike Gallant wrote:

Hi all,

I am having difficultly with amanda 2.5.1p3 recognizing the solaris 10, zfs, holding disk.

WARNING: holding disk /amanda: only 0 MB free (2000 MB requested)

I get the same message with amdump (which is the bigger issue).

Any thoughts?

Thanks,
Mike

bash-3.00# su amanda -c "/opt/slis/sbin/amcheck -l mwf"
Amanda Tape Server Host Check
-----------------------------
WARNING: holding disk /amanda: only 0 MB free (2000 MB requested)
NOTE: skipping tape checks
Server check took 0.013 seconds

Havn't tried 2.5.1p3 yet, the attached patch works for me with 2.5.1p2 and zfs holding disks. A simple change of a line back to an earlier version made it work again.

 Cheers, Peter
------------------------------------------------------------------------

*** common-src/statfs.c Thu Apr 26 08:20:35 2007
--- common-src/statfs.c-2.5.1p2 Thu Aug 24 19:05:35 2006
***************
*** 128,131 ****
--- 128,132 ----
  #endif

+ off_t scale(off_t r, off_t s); ***************

*** 137,141 ****
      if (r == (off_t)-1)
        return (off_t)-1;
!     return r*((double)s/(off_t)1024);
  }

--- 138,142 ----

      if (r == (off_t)-1)
        return (off_t)-1;
!     return r*(s/(off_t)1024);
  }