Amanda-Users

Re: Release of amanda-2.5.0b2

2006-02-22 12:34:58
Subject: Re: Release of amanda-2.5.0b2
From: Jon LaBadie <jon AT jgcomp DOT com>
To: amanda-users AT amanda DOT org
Date: Wed, 22 Feb 2006 12:27:32 -0500
On Wed, Feb 22, 2006 at 08:24:00AM -0800, Kevin Till wrote:
>
> >>HOSTNAME     DISK   L ORIG-MB OUT-MB COMP% CRYPT% MMM:SS  KB/s MMM:SS  
> >>--------------------- ---------------------------------------- 
> >>host.do.main /m/b   2     509    139  27.3   1:561231.2   N/A   N/A
> >>
> >>
> >>The real dump duration was about 115 seconds, but amdump says 1231.2 
> >>minutes.
> >>Note that the "kps" filed in the logfile contains the value that is 
> >>reported
> >>my the mail.
> >>
> >
> 
> I have checked in code to remove "CRYPT%".
> 
> 
> The following patch by John Franks will help too:
> --- server-src/conffile.c       28 Jan 2006 01:40:13 -0000      1.122
> +++ server-src/conffile.c       18 Feb 2006 01:55:07 -0000      1.123
> @@ -25,7 +25,7 @@
>   *                        University of Maryland at College Park
>   */
>  /*
> - * $Id: conffile.c,v 1.122 2006/01/28 01:40:13 paddy Exp $
> + * $Id: conffile.c,v 1.123 2006/02/18 01:55:07 jfranks Exp $
>   *
>   * read configuration file
>   */
> @@ -144,12 +144,12 @@
>      { "Disk",       1, 11, 11, 0, "%-*.*s", "DISK" },
>      { "Level",      1, 1,  1,  0, "%*.*d",  "L" },
>      { "OrigKB",     1, 7,  0,  0, "%*.*f",  "ORIG-KB" },
> -    { "OutKB",      0, 7,  0,  0, "%*.*f",  "OUT-KB" },
> -    { "Compress",   0, 6,  1,  0, "%*.*f",  "COMP%" },
> -    { "DumpTime",   0, 7,  7,  0, "%*.*s",  "MMM:SS" },
> -    { "DumpRate",   0, 6,  1,  0, "%*.*f",  "KB/s" },
> +    { "OutKB",      1, 7,  0,  0, "%*.*f",  "OUT-KB" },
> +    { "Compress",   1, 6,  1,  0, "%*.*f",  "COMP%" },
> +    { "DumpTime",   1, 7,  7,  0, "%*.*s",  "MMM:SS" },
> +    { "DumpRate",   1, 6,  1,  0, "%*.*f",  "KB/s" },
>      { "TapeTime",   1, 6,  6,  0, "%*.*s",  "MMM:SS" },
> -    { "TapeRate",   0, 6,  1,  0, "%*.*f",  "KB/s" },
> +    { "TapeRate",   1, 6,  1,  0, "%*.*f",  "KB/s" },
>      { NULL,         0, 0,  0,  0, NULL,     NULL }
>  };
> 

INMNSO the default precision for the "*Rate" parameters and
maybe for the "Compress" parameter also, should be changed
to "0".  As in:

  -    { "TapeRate",   1, 6,  1,  0, "%*.*f",  "KB/s" },
  +    { "TapeRate",   1, 6,  0,  0, "%*.*f",  "KB/s" },

Does anyone really care if the rate was 1231.3 or 1231.4 KB/s?
Not only does a percision of zero get rid of the useless digit,
also the decimal point is eliminated.  Thus two character
positions are gained.

-- 
Jon H. LaBadie                  jon AT jgcomp DOT com
 JG Computing
 4455 Province Line Road        (609) 252-0159
 Princeton, NJ  08540-4322      (609) 683-7220 (fax)

<Prev in Thread] Current Thread [Next in Thread>