BackupPC-users

Re: [BackupPC-users] rsync --exclude options - why are they stripped?

2014-11-12 12:26:22
Subject: Re: [BackupPC-users] rsync --exclude options - why are they stripped?
From: Holger Parplies <wbppc AT parplies DOT de>
To: backuppc-users AT lists.sourceforge DOT net
Date: Wed, 12 Nov 2014 18:23:44 +0100
Hi,

mwilck wrote on 2014-11-12 05:29:23 -0800 [[BackupPC-users] rsync --exclude 
options - why are they stripped?]:
> [...]
> The Documentation of RsyncArgsExtra [...] mentions explicity its usefulness
> for defining rsync-style include/exclude rules [...]. The code explicity
> removes these options with the following  line in Rsync.pm:
> [...]
> Why does BackupPC strip the rsync exclude options?

I'd have to look at the current code closely to be sure, but from memory,
rsync sends the in-/excludes via the rsync protocol exchange rather than on
the command line. Your XferLOG should contain lines starting with
"Sent exclude" (or include, I suppose). I remember the code moving also
in-/excludes from the RsyncArgsExtra (or was it RsyncArgs?) and not only
applying this to the in-/excludes it generates itself. I don't recall the
order in which they are sent, but putting the ones from RsyncArgsExtra
first would seem to make most sense.

This may have been changed by the patch you mention. I'll look into it,
when I find the time. Does your XferLOG include any "Sent exclude" lines?

Aside from RsyncArgsExtra, you should also be able to put arbitrary rsync
style in-/exclude rules in the BackupFilesExclude list, as these are passed
verbatim to rsync (also via the protocol exchange, I believe). RsyncFilesOnly,
on the other hand, is used to generate sets of includes and excludes.

Regards,
Holger

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk
_______________________________________________
BackupPC-users mailing list
BackupPC-users AT lists.sourceforge DOT net
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:    http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/