Re: [BackupPC-users] Odd 'unexpected repeated share name error'

On Sun, Feb 14, 2010 at 01:39:23PM -0800, Craig Barratt wrote:
> If you want to try the two fixes, here's a patch against 3.2.0beta1
> (note: I haven't tested this yet - just did this sitting on a plane).
> 
> Craig
> 
> --- bin/BackupPC_dump 2010-01-24 17:30:43.000000000 -0800
> +++ bin/BackupPC_dump 2010-02-14 12:02:14.859375000 -0800
> @@ -623,6 +623,7 @@
>  #
>  # Now backup each of the shares
>  #
> +my $shareDuplicate = {};
>  for my $shareName ( @$ShareNames ) {
>      local(*RH, *WH);
>  
> @@ -632,11 +633,17 @@
>      $shareName = encode("utf8", $shareName);
>      $stat{xferOK} = $stat{hostAbort} = undef;
>      $stat{hostError} = $stat{lastOutputLine} = undef;
> -    if ( -d "$Dir/new/$shareName" ) {
> +    if ( $shareName eq "" ) {
> +        print(LOG $bpc->timeStamp,
> +                  "unexpected empty share name skipped\n");
> +        next;
> +    }
> +    if ( $shareDuplicate->{$shareName} ) {
>          print(LOG $bpc->timeStamp,
>                    "unexpected repeated share name $shareName skipped\n");
>          next;
>      }
> +    $shareDuplicate->{$shareName} = 1;
>  
>      UserCommandRun("DumpPreShareCmd", $shareName);
>      if ( $? && $Conf{UserCmdCheckStatus} ) {
> @@ -915,6 +922,10 @@
>          #
>          last;
>      }
> +    #
> +    # Wait for any child processes to exit
> +    #
> +    1 while ( wait() >= 0 );
>  }
>  
>  #

I hand applied the zombie fix around line 915 and that resulted in all
the backups reporting:

  2010-02-18 14:25:57 DumpPreShareCmd returned error status -1... exiting

I rolled back the change. Any ideas?

-- 
                                -- rouilj

John Rouillard       System Administrator
Renesys Corporation  603-244-9084 (cell)  603-643-9300 x 111

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
BackupPC-users mailing list
BackupPC-users AT lists.sourceforge DOT net
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:    http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/