BackupPC-users

Re: [BackupPC-users] BUG in backuppc md5sum calculation for root attrib files (WAS: cpool md5sum errors with certain attrib files)

2010-01-10 22:49:24
Subject: Re: [BackupPC-users] BUG in backuppc md5sum calculation for root attrib files (WAS: cpool md5sum errors with certain attrib files)
From: Craig Barratt <cbarratt AT users.sourceforge DOT net>
To: "Jeffrey J. Kosowsky" <backuppc AT kosowsky DOT org>
Date: Sun, 10 Jan 2010 19:47:50 -0800
Jeff writes:

>  > The md5sum for the root level attrib (i.e., the attrib file at the
>  > level of pc/machine/attrib) is wrong if:
>  > 1. There are at least 2 shares
>  > 2. The attrib entries for each of the shares has changed since the
>  >    last backup (e.g., if the share directory has it's mtime modified
> 
> OK. I found the bug. NOTE THIS BUG AFFECTS EVERYBODY WHO IS BACKING UP
> MORE THAN ONE SHARE -- i.e., everybody backing up more than one file
> has such pool errors though they should not effect data integrity,
> only pooling efficiency.

Nice detective work!  Your explanation is 100% right.

> 4. Maybe the best approach would be to modify the loop so it skips
>    over all instances of the base attrib file until the last one.

I've applied your patch #4, with one slight change:

>                          @shareattrib=($1, $2, "$CurrDumpDir/$3");

instead of

>                          @shareattrib=($1, $2, $3);

Thanks,
Craig

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
BackupPC-users mailing list
BackupPC-users AT lists.sourceforge DOT net
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:    http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [BackupPC-users] BUG in backuppc md5sum calculation for root attrib files (WAS: cpool md5sum errors with certain attrib files), Craig Barratt <=